fix: unify Exchange.market_close signature to use 'name' instead of 'coin'#266
Open
KyaClaw wants to merge 1 commit intohyperliquid-dex:masterfrom
Open
fix: unify Exchange.market_close signature to use 'name' instead of 'coin'#266KyaClaw wants to merge 1 commit intohyperliquid-dex:masterfrom
KyaClaw wants to merge 1 commit intohyperliquid-dex:masterfrom
Conversation
olzhang
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR unifies the parameter name in
Exchange.market_closefromcointoname, aligning it with the rest of the SDK's API consistency.Changes
cointonameinExchange.market_closemethod signatureTesting
The fix maintains backward compatibility as it's only a parameter rename. Existing code calling
market_close(coin="BTC")will need to update tomarket_close(name="BTC").Fixes #264